Fix: Finalise Tax Year Button Now Enables Correctly After HMRC Acceptance

Release: v1.0.453
Date: 2025-07-14
Affected area: Quarterly Submissions → Finalise Tax Year

What Was Happening

After successfully submitting all four quarterly updates and receiving HMRC acceptance on each one, the Finalise Tax Year button on /dashboard/quarterly remained permanently disabled. The progress indicator showed "0 of 4 quarters submitted" regardless of how many quarters HMRC had accepted.

This meant users who had fully completed their quarterly obligations — and had the HMRC acceptance records to prove it — were blocked from moving on to their annual summary and final declaration.

Why It Happened

HMRC's Making Tax Digital API uses two distinct status values during the submission lifecycle:

Status	Meaning
`submitted`	The quarterly update has been sent to HMRC and is awaiting processing
`accepted`	HMRC has confirmed the update is valid and has been recorded

The readiness check for the Finalise Tax Year button counted only quarters in submitted state. Once HMRC processed a submission and moved it to accepted, that quarter was no longer counted — even though accepted is a strictly more complete state than submitted.

The server-side validation (FINALISATION_READY_STATUSES in submission.ts) already handled this correctly by treating both statuses as ready. The UI and the API were out of sync.

What Changed

The filter in finalise-tax-year-section.tsx has been updated to count a quarter as ready if its status is either submitted or accepted:

// Before (v1.0.452 and earlier)
const submittedCount = submissions.filter(
  (s) => s.status === 'submitted'
).length;

// After (v1.0.453)
const submittedCount = submissions.filter(
  (s) => s.status === 'submitted' || s.status === 'accepted'
).length;

The Finalise Tax Year button now enables — and the quarter count displays correctly — as soon as all four quarters reach either submitted or accepted status. No other logic was modified.

What You Need to Do

Nothing. This is a front-end-only fix with no data migration or configuration changes required. If you were previously blocked from finalising your tax year, simply revisit /dashboard/quarterly and the button will now be available.

Affected Users

Any user who:

Submitted all four quarterly updates for a tax year, and
Received HMRC acceptance on all four quarters, and
Had not yet completed their final declaration

was affected by this bug. Submissions, acceptance records, and all underlying data remain intact.